Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing or move incorrect semicolons #393

Merged

Conversation

kdayday
Copy link
Contributor

@kdayday kdayday commented Aug 19, 2024

Missing or incorrect semicolon placement in function definitions was leading to multiple signatures in the documentation

May break calls for these functions:

  • open_file_logger
  • list_recorder_events
  • show_recorder_events
  • get_time_series_multiple
  • read_time_series
  • get_time_series
  • get_time_series_array
  • get_time_series_timestamps
  • get_time_series_values

@kdayday kdayday requested a review from daniel-thom August 19, 2024 18:28
@kdayday
Copy link
Contributor Author

kdayday commented Aug 19, 2024

Tagging @daniel-thom in case this broke any tests

Copy link
Member

@jd-lara jd-lara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kdayday you need to update the calls to the functions you broke as well. The tests are failing because the call to open the file logger broke with the change made in logging.jl

@jd-lara jd-lara changed the base branch from main to jd/fix_semicolon_inconsistency September 9, 2024 19:19
@jd-lara jd-lara merged commit 0462a5e into NREL-Sienna:jd/fix_semicolon_inconsistency Sep 9, 2024
2 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants